Page MenuHomePhabricator
Differential D17878

Make a handful of minor Slowvote behaviors more consistent with other applications
ClosedPublic
Actions

Authored by epriestley on May 14 2017, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Sun, Apr 21, 1:31 AM
Unknown Object (File)
Fri, Apr 19, 6:29 PM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
Unknown Object (File)
Fri, Mar 29, 3:44 AM
Unknown Object (File)
Feb 27 2024, 2:07 PM
Unknown Object (File)
Feb 23 2024, 12:57 PM
Unknown Object (File)
Feb 23 2024, 12:10 PM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Maniphest Tasks
T12685: Modular Transactions Migrations Errata
Commits
rPc7a642255997: Make a handful of minor Slowvote behaviors more consistent with other…
Summary

Ref T12685.

  • Better icon/color/label consistency.
  • Make "0" a valid response.
  • Fix a bug where creating a poll with Quicksand enabled led to bad times (form submitted back to the search screen).
Test Plan

Screen Shot 2017-05-14 at 1.51.04 PM.png (1×1 px, 154 KB)

Diff Detail

Repository
rP Phabricator
Branch
err4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16923
Build 22615: Run Core Tests
Build 22614: arc lint + arc unit

Event Timeline

epriestley created this revision.May 14 2017, 8:51 PM
Harbormaster completed remote builds in B16922: Diff 42998.May 14 2017, 8:52 PM
epriestley updated this revision to Diff 43000.May 14 2017, 8:54 PM
  • Bonus! Change creation string from "created this object" to "created this poll".
Harbormaster completed remote builds in B16923: Diff 43000.May 14 2017, 8:55 PM
chad accepted this revision.May 14 2017, 8:56 PM
This revision is now accepted and ready to land.May 14 2017, 8:56 PM
Closed by commit rPc7a642255997: Make a handful of minor Slowvote behaviors more consistent with other… (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2017, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43000

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
Phabricator · Built by Phacility