Page MenuHomePhabricator

In Applications, always redirect back to the detail page after edits
ClosedPublic

Authored by epriestley on May 14 2017, 8:42 PM.
Tags
None
Referenced Files
F18747140: D17877.id.diff
Fri, Oct 3, 2:54 PM
F18703789: D17877.id42997.diff
Sun, Sep 28, 5:05 AM
F18622976: D17877.diff
Mon, Sep 15, 1:45 PM
F18613446: D17877.diff
Sun, Sep 14, 11:12 AM
F18566299: D17877.id.diff
Tue, Sep 9, 2:27 PM
F18501019: D17877.diff
Thu, Sep 4, 9:29 PM
F18439420: D17877.id.diff
Aug 31 2025, 2:59 PM
F18100369: D17877.id.diff
Aug 9 2025, 11:51 AM
Subscribers
None

Details

Summary

Ref T12685. When you edit an application's policies but don't make any changes, you currently get stuck on the same page. This isn't how other edit screens work, and I think it's a holdover from eras long ago.

Make it consistent with other applications.

Also, fix a missing pht().

Test Plan
  • Edited an application configuation.
  • Clicked "Save" without making changes.
  • After patch, was redirected back to detail page like in other applications.

Diff Detail

Repository
rP Phabricator
Branch
err3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16921
Build 22611: Run Core Tests
Build 22610: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 14 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.