Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
F15451648: D17876.id42995.diff
Fri, Mar 28, 11:08 PM
F15449533: D17876.diff
Fri, Mar 28, 10:49 AM
F15445239: D17876.id43002.diff
Thu, Mar 27, 1:04 PM
F15444617: D17876.id.diff
Thu, Mar 27, 10:24 AM
F15436289: D17876.id.diff
Tue, Mar 25, 1:09 PM
F15433442: D17876.diff
Mon, Mar 24, 11:12 PM
F15429565: D17876.id42995.diff
Mon, Mar 24, 2:58 AM
F15423888: D17876.id42995.diff
Sat, Mar 22, 7:14 PM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Branch
err2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16919
Build 22608: Run Core Tests
Build 22607: arc lint + arc unit