Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
F14089148: D17876.id42995.diff
Sun, Nov 24, 8:29 AM
Unknown Object (File)
Thu, Nov 21, 9:48 AM
Unknown Object (File)
Thu, Nov 21, 3:50 AM
Unknown Object (File)
Sun, Nov 17, 2:45 AM
Unknown Object (File)
Oct 20 2024, 12:19 PM
Unknown Object (File)
Oct 15 2024, 4:43 AM
Unknown Object (File)
Oct 9 2024, 8:00 AM
Unknown Object (File)
Sep 13 2024, 1:40 PM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Branch
err2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16919
Build 22608: Run Core Tests
Build 22607: arc lint + arc unit