Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
F18740251: D17876.diff
Thu, Oct 2, 1:26 AM
F18407133: D17876.diff
Aug 30 2025, 12:46 AM
F18112866: D17876.id43002.diff
Aug 12 2025, 9:36 PM
F18105942: D17876.id42995.diff
Aug 10 2025, 8:37 PM
F18099281: D17876.diff
Aug 9 2025, 3:24 AM
F18097089: D17876.id.diff
Aug 8 2025, 11:05 AM
F17950121: D17876.diff
Aug 1 2025, 12:08 AM
Unknown Object (File)
May 31 2025, 11:23 AM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Branch
err2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16919
Build 22608: Run Core Tests
Build 22607: arc lint + arc unit