Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
F20643251: D17876.id42995.diff
Sun, Jun 21, 12:54 AM
Unknown Object (File)
Feb 14 2026, 11:59 AM
Unknown Object (File)
Feb 14 2026, 11:54 AM
Unknown Object (File)
Feb 10 2026, 11:15 AM
Unknown Object (File)
Jan 20 2026, 2:17 PM
Unknown Object (File)
Jan 19 2026, 2:18 PM
Unknown Object (File)
Jan 17 2026, 8:27 AM
Unknown Object (File)
Jan 17 2026, 8:27 AM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Branch
err2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16919
Build 22608: Run Core Tests
Build 22607: arc lint + arc unit