Page MenuHomePhabricator

Fix file attach bug in Macro
ClosedPublic

Authored by chad on May 6 2017, 2:43 AM.
Tags
None
Referenced Files
F14125589: D17836.id42909.diff
Sat, Nov 30, 10:24 AM
Unknown Object (File)
Tue, Nov 26, 10:44 AM
Unknown Object (File)
Thu, Nov 21, 12:38 AM
Unknown Object (File)
Wed, Nov 20, 8:21 AM
Unknown Object (File)
Sat, Nov 16, 12:43 AM
Unknown Object (File)
Tue, Nov 12, 7:58 AM
Unknown Object (File)
Tue, Nov 12, 7:00 AM
Unknown Object (File)
Mon, Nov 11, 1:41 PM
Subscribers

Details

Summary

This was mis-tested by only using one account, which could always see the image. External transaction moved file attachment to the modular transaction for file and audio instead.

Test Plan

Test adding audio and a macro on a pleb account, visit with normal account and see macro fine.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 6 2017, 2:46 AM

(I'll cherry-pick this before deploying tomorrow.)

This revision was automatically updated to reflect the committed changes.

ive learned so much about transactions this week