Page MenuHomePhabricator

Fix file attach bug in Macro
ClosedPublic

Authored by chad on May 6 2017, 2:43 AM.
Tags
None
Referenced Files
F13145601: D17836.diff
Fri, May 3, 9:11 AM
Unknown Object (File)
Wed, May 1, 7:58 AM
Unknown Object (File)
Thu, Apr 25, 2:49 AM
Unknown Object (File)
Mon, Apr 22, 5:20 AM
Unknown Object (File)
Sat, Apr 13, 6:27 AM
Unknown Object (File)
Thu, Apr 11, 10:08 AM
Unknown Object (File)
Mar 29 2024, 6:14 PM
Unknown Object (File)
Mar 24 2024, 10:21 PM
Subscribers

Details

Summary

This was mis-tested by only using one account, which could always see the image. External transaction moved file attachment to the modular transaction for file and audio instead.

Test Plan

Test adding audio and a macro on a pleb account, visit with normal account and see macro fine.

Diff Detail

Repository
rP Phabricator
Branch
restricted-file (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16834
Build 22468: Run Core Tests
Build 22467: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 6 2017, 2:46 AM

(I'll cherry-pick this before deploying tomorrow.)

This revision was automatically updated to reflect the committed changes.

ive learned so much about transactions this week