Fixes T12659. Previously this would lead to an error when trying to run arc diff on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T12659: arc diff errors when a milestone is a group reviewer
- Commits
- rPf2ca348b3a7a: Set project's ObjectName to its PHID when it doesn't have a hashtag
Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- FixProjectParseError (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16747 Build 22341: Run Core Tests Build 22340: arc lint + arc unit