Page MenuHomePhabricator

Set project's ObjectName to its PHID when it doesn't have a hashtag
ClosedPublic

Authored by jcox on May 1 2017, 1:19 PM.
Tags
None
Referenced Files
F13050047: D17807.id42821.diff
Fri, Apr 19, 2:35 AM
F13050046: D17807.id42820.diff
Fri, Apr 19, 2:35 AM
F13050045: D17807.id.diff
Fri, Apr 19, 2:35 AM
Unknown Object (File)
Thu, Apr 11, 8:11 AM
Unknown Object (File)
Thu, Apr 11, 3:56 AM
Unknown Object (File)
Tue, Apr 2, 11:37 AM
Unknown Object (File)
Sun, Mar 31, 12:08 PM
Unknown Object (File)
Sat, Mar 30, 4:35 AM
Subscribers

Details

Summary

Fixes T12659. Previously this would lead to an error when trying to run arc diff on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)

Test Plan

Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable