Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
F13229385: D17787.diff
Mon, May 20, 4:10 PM
F13182469: D17787.diff
Thu, May 9, 11:30 PM
F13176609: D17787.id42771.diff
Wed, May 8, 3:34 PM
Unknown Object (File)
Mon, May 6, 2:09 AM
Unknown Object (File)
Thu, May 2, 3:04 AM
Unknown Object (File)
Thu, Apr 25, 12:34 AM
Unknown Object (File)
Apr 17 2024, 2:39 PM
Unknown Object (File)
Apr 15 2024, 12:24 PM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable