Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
F19707171: D17787.diff
Wed, Feb 11, 10:51 AM
F19560669: D17787.id42778.diff
Sat, Jan 31, 8:03 AM
F19555123: D17787.id42771.diff
Fri, Jan 30, 8:54 AM
F19554592: D17787.id42778.diff
Fri, Jan 30, 12:04 AM
F19554340: D17787.id42778.diff
Thu, Jan 29, 8:49 PM
F19527902: D17787.id.diff
Jan 19 2026, 5:15 AM
F19525175: D17787.diff
Jan 18 2026, 6:56 AM
F19507694: D17787.diff
Jan 9 2026, 10:28 PM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable