Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 1:43 AM
Unknown Object (File)
Sat, Nov 16, 4:16 PM
Unknown Object (File)
Sat, Nov 9, 1:33 PM
Unknown Object (File)
Sat, Nov 9, 1:33 PM
Unknown Object (File)
Sat, Nov 9, 1:32 PM
Unknown Object (File)
Tue, Nov 5, 11:49 PM
Unknown Object (File)
Oct 8 2024, 6:21 AM
Unknown Object (File)
Sep 24 2024, 4:54 AM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Branch
T12555 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16698
Build 22272: Run Core Tests
Build 22271: arc lint + arc unit