Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
F15283271: D17787.id42771.diff
Tue, Mar 4, 6:29 AM
Unknown Object (File)
Sun, Feb 16, 10:20 PM
Unknown Object (File)
Jan 17 2025, 8:49 PM
Unknown Object (File)
Jan 10 2025, 7:21 AM
Unknown Object (File)
Jan 4 2025, 10:55 AM
Unknown Object (File)
Jan 2 2025, 4:52 AM
Unknown Object (File)
Dec 31 2024, 10:19 AM
Unknown Object (File)
Dec 21 2024, 3:53 PM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable