Fixes T12555.
Details
Details
Added this class to the codebase and ran arc liberate:
<?php class FooBar { public static function doTheFoo() { return 'foobar'; } }
Ran arc lint and observed this warning:
Warning (XHP87) Class Not `abstract` Or `final`
This class is neither `final` nor `abstract`, and does not have a
docblock marking it `@concrete-extensible`.
1 <?php
2
>>> 3 class FooBar {
4 public static function doTheFoo() {
5 return "foobar";
6 }Added a final modifier to FooBar's declaration and observed the warning went away.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- T12555 (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16698 Build 22272: Run Core Tests Build 22271: arc lint + arc unit