Page MenuHomePhabricator

Make "fail quietly" flag in DeferredLog a little more quiet
ClosedPublic

Authored by epriestley on Apr 23 2017, 2:37 PM.
Tags
None
Referenced Files
F15421181: D17777.diff
Fri, Mar 21, 9:30 PM
F15383382: D17777.diff
Fri, Mar 14, 4:28 PM
F15380668: D17777.diff
Fri, Mar 14, 4:02 AM
F15378418: D17777.id42740.diff
Thu, Mar 13, 2:20 PM
F15375909: D17777.id42748.diff
Thu, Mar 13, 12:41 AM
Unknown Object (File)
Mon, Feb 24, 2:08 PM
Unknown Object (File)
Feb 16 2025, 9:08 PM
Unknown Object (File)
Jan 28 2025, 2:31 AM
Subscribers
None

Details

Summary

Ref T12611. Currently, access logs have a "setFailQuietly(true)" flag set on them (rationale: the webserver should still work if the log volume fills up or logs are otherwise not correctly configured) but it's only somewhat quiet.

Make it quieter when the log directory itself (not just the logfile) doesn't exist or can't be created.

(If installs run into confusion with this, we could more reasonably raise a setup warning instead.)

Test Plan

With a missing logfile directory, saw a log about being unable to log instead of an exception.

Diff Detail

Repository
rPHU libphutil
Branch
log1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16669
Build 22234: Run Core Tests
Build 22233: arc lint + arc unit

Event Timeline

epriestley added a child revision: Restricted Differential Revision.Apr 23 2017, 2:57 PM
This revision is now accepted and ready to land.Apr 23 2017, 3:14 PM
This revision was automatically updated to reflect the committed changes.