Page MenuHomePhabricator

Make "fail quietly" flag in DeferredLog a little more quiet
ClosedPublic

Authored by epriestley on Apr 23 2017, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 11:13 AM
Unknown Object (File)
Fri, Apr 26, 3:16 PM
Unknown Object (File)
Mon, Apr 22, 11:20 AM
Unknown Object (File)
Fri, Apr 5, 10:34 PM
Unknown Object (File)
Mar 16 2024, 3:33 AM
Unknown Object (File)
Feb 6 2024, 11:21 PM
Unknown Object (File)
Jan 7 2024, 5:24 PM
Unknown Object (File)
Dec 31 2023, 11:57 AM
Subscribers
None

Details

Summary

Ref T12611. Currently, access logs have a "setFailQuietly(true)" flag set on them (rationale: the webserver should still work if the log volume fills up or logs are otherwise not correctly configured) but it's only somewhat quiet.

Make it quieter when the log directory itself (not just the logfile) doesn't exist or can't be created.

(If installs run into confusion with this, we could more reasonably raise a setup warning instead.)

Test Plan

With a missing logfile directory, saw a log about being unable to log instead of an exception.

Diff Detail

Repository
rPHU libphutil
Branch
log1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16669
Build 22234: Run Core Tests
Build 22233: arc lint + arc unit

Event Timeline

epriestley added a child revision: Restricted Differential Revision.Apr 23 2017, 2:57 PM
This revision is now accepted and ready to land.Apr 23 2017, 3:14 PM
This revision was automatically updated to reflect the committed changes.