Paths

Table of Contentst

Differential D17732

Fix improper filtering behavior in ConpherenceParticipantQuery
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 7:52 PM.

Tags

None

Referenced Files

	F15485985: D17732.id42647.diff
	Thu, Apr 10, 4:05 AM

	F15474505: D17732.id42657.diff
	Sun, Apr 6, 9:36 AM

	F15386484: D17732.diff
	Mar 15 2025, 12:41 AM

	F15386382: D17732.id42657.diff
	Mar 15 2025, 12:27 AM

	F15381380: D17732.diff
	Mar 14 2025, 7:21 AM

	F15367976: D17732.diff
	Mar 11 2025, 10:50 PM

	Unknown Object (File)
	Feb 9 2025, 3:51 AM

	Unknown Object (File)
	Feb 9 2025, 3:51 AM

Subscribers

None

Details

Reviewers

Commits

rPf46263903cbe: Fix improper filtering behavior in ConpherenceParticipantQuery

Summary

Pathway to D17685. This fixes an issue idenified in D17731: if any caller ever queried for more than one participant, some results could get thrown away by re-keying the results on thread PHID: two different participants can be members of the same thread!

This also fixes an issue from D17683, where a needParticipantCache() callsite was overlooked.

Test Plan

Viewed Conpherence dropdown.
Sent messages, saw unread count / thread order still work properly.

Diff Detail

Repository

Branch

status4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16582
Build 22108: Run Core Tests
Build 22107: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 7:52 PM

Harbormaster completed remote builds in B16582: Diff 42647.Apr 19 2017, 7:53 PM

chad accepted this revision.Apr 19 2017, 7:58 PM

This revision is now accepted and ready to land.Apr 19 2017, 7:58 PM

Closed by commit rPf46263903cbe: Fix improper filtering behavior in ConpherenceParticipantQuery (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

conduit/

ConpherenceQueryThreadConduitAPIMethod.php

5 lines

controller/

ConpherenceListController.php

1 line

ConpherenceNotificationPanelController.php

1 line

query/

ConpherenceParticipantQuery.php

17 lines

Diff 42647

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

Loading...

src/applications/conpherence/controller/ConpherenceListController.php

Loading...

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...

src/applications/conpherence/query/ConpherenceParticipantQuery.php

Loading...