HomePhabricator

Fix improper filtering behavior in ConpherenceParticipantQuery

Description

Fix improper filtering behavior in ConpherenceParticipantQuery

Summary:
Pathway to D17685. This fixes an issue idenified in D17731: if any caller ever queried for more than one participant, some results could get thrown away by re-keying the results on thread PHID: two different participants can be members of the same thread!

This also fixes an issue from D17683, where a needParticipantCache() callsite was overlooked.

Test Plan:

  • Viewed Conpherence dropdown.
  • Sent messages, saw unread count / thread order still work properly.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17732

Details

Provenance
epriestleyAuthored on Apr 19 2017, 7:49 PM
epriestleyPushed on Apr 19 2017, 8:59 PM
Reviewer
chad
Differential Revision
D17732: Fix improper filtering behavior in ConpherenceParticipantQuery
Parents
rP76d0b67d91cf: Remove "dateTouched" from ConpherenceParticipant
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16592
Build 22122: Run Core Tests