Paths

Table of Contentst

Differential D17732

Fix improper filtering behavior in ConpherenceParticipantQuery
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 7:52 PM.

Tags

None

Referenced Files

	F15667264: D17732.diff
	Sun, May 25, 11:42 AM

	Unknown Object (File)
	Sat, May 24, 7:04 AM

	Unknown Object (File)
	Fri, May 9, 7:18 PM

	Unknown Object (File)
	Fri, May 9, 3:44 PM

	Unknown Object (File)
	Apr 21 2025, 2:33 AM

	Unknown Object (File)
	Apr 21 2025, 1:24 AM

	Unknown Object (File)
	Apr 17 2025, 6:46 PM

	Unknown Object (File)
	Apr 16 2025, 5:42 PM

Subscribers

None

Details

Reviewers

Commits

rPf46263903cbe: Fix improper filtering behavior in ConpherenceParticipantQuery

Summary

Pathway to D17685. This fixes an issue idenified in D17731: if any caller ever queried for more than one participant, some results could get thrown away by re-keying the results on thread PHID: two different participants can be members of the same thread!

This also fixes an issue from D17683, where a needParticipantCache() callsite was overlooked.

Test Plan

Viewed Conpherence dropdown.
Sent messages, saw unread count / thread order still work properly.

Diff Detail

Repository

Branch

status4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16582
Build 22108: Run Core Tests
Build 22107: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 7:52 PM

Harbormaster completed remote builds in B16582: Diff 42647.Apr 19 2017, 7:53 PM

chad accepted this revision.Apr 19 2017, 7:58 PM

This revision is now accepted and ready to land.Apr 19 2017, 7:58 PM

Closed by commit rPf46263903cbe: Fix improper filtering behavior in ConpherenceParticipantQuery (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

conduit/

ConpherenceQueryThreadConduitAPIMethod.php

5 lines

controller/

ConpherenceListController.php

1 line

ConpherenceNotificationPanelController.php

1 line

query/

ConpherenceParticipantQuery.php

17 lines

Diff 42647

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

Loading...

src/applications/conpherence/controller/ConpherenceListController.php

Loading...

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...

src/applications/conpherence/query/ConpherenceParticipantQuery.php

Loading...