Page MenuHomePhabricator

Remove "dateTouched" from ConpherenceParticipant
ClosedPublic

Authored by epriestley on Apr 19 2017, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:30 AM
Unknown Object (File)
Thu, Mar 7, 11:10 PM
Unknown Object (File)
Thu, Mar 7, 10:15 PM
Unknown Object (File)
Thu, Mar 7, 10:14 PM
Unknown Object (File)
Thu, Mar 7, 7:19 PM
Unknown Object (File)
Jan 28 2024, 7:52 AM
Unknown Object (File)
Dec 24 2023, 4:09 PM
Unknown Object (File)
Dec 24 2023, 4:09 PM
Subscribers
None

Details

Summary

Pathway to D17685. This column is (mostly) a denormalization of dateModified on the thread.

Just use a JOIN instead.

This isn't exactly the same: we'll bump threads to the top now for non-message changes (e.g., a topic or title change). That seems fine, but we could put a lastMessageDate on Thread later if we want to refine it.

Also got rid of a lot of other unused stuff. There's a big garbage TODO here, I'll fix that in the next change.

Test Plan
  • Grepped for dateTouched.
  • Grepped for participantCursor.
  • Grepped for ConpherenceParticipantQuery::LIMIT.
  • Looked for callsites to setOrder(), found none.
  • Added a message to an older thread, saw it bump up to the top.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable