Page MenuHomePhabricator

Remove "dateTouched" from ConpherenceParticipant
ClosedPublic

Authored by epriestley on Apr 19 2017, 7:42 PM.
Tags
None
Referenced Files
F14012745: D17731.diff
Fri, Nov 1, 5:29 PM
Unknown Object (File)
Oct 13 2024, 9:15 PM
Unknown Object (File)
Aug 17 2024, 2:46 AM
Unknown Object (File)
Aug 15 2024, 10:58 AM
Unknown Object (File)
Aug 15 2024, 8:10 AM
Unknown Object (File)
Aug 6 2024, 7:56 PM
Unknown Object (File)
Aug 6 2024, 2:15 AM
Unknown Object (File)
Jul 26 2024, 9:50 AM
Subscribers
None

Details

Summary

Pathway to D17685. This column is (mostly) a denormalization of dateModified on the thread.

Just use a JOIN instead.

This isn't exactly the same: we'll bump threads to the top now for non-message changes (e.g., a topic or title change). That seems fine, but we could put a lastMessageDate on Thread later if we want to refine it.

Also got rid of a lot of other unused stuff. There's a big garbage TODO here, I'll fix that in the next change.

Test Plan
  • Grepped for dateTouched.
  • Grepped for participantCursor.
  • Grepped for ConpherenceParticipantQuery::LIMIT.
  • Looked for callsites to setOrder(), found none.
  • Added a message to an older thread, saw it bump up to the top.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable