Page MenuHomePhabricator

Change PhabricatorPhurlURLViewController to use EditEngine for commenting
ClosedPublic

Authored by amckinley on Apr 13 2017, 11:36 PM.
Tags
None
Referenced Files
F13145690: D17686.diff
Fri, May 3, 9:15 AM
Unknown Object (File)
Wed, May 1, 11:50 PM
Unknown Object (File)
Wed, May 1, 2:28 PM
Unknown Object (File)
Sat, Apr 27, 7:28 AM
Unknown Object (File)
Thu, Apr 25, 8:31 PM
Unknown Object (File)
Thu, Apr 25, 2:52 AM
Unknown Object (File)
Thu, Apr 11, 10:18 AM
Unknown Object (File)
Tue, Apr 9, 7:29 PM
Subscribers

Details

Test Plan

Created a phurl, added some comments, confirmed that "Change Subscribers" and "Change Project Tags" are now available in the comment form.

Diff Detail

Repository
rP Phabricator
Branch
T11661 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16465
Build 21918: Run Core Tests
Build 21917: arc lint + arc unit

Event Timeline

chad added inline comments.
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
71

Shouldn't need this div.

One minor fix beyond @chad's note.

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
33

While we're here, you can also add:

$timeline->setQuoteRef($url->getMonogram());

That should make the "Quote Comment" action available from the dropdown on the right hand side of comments in the timeline correctly quote comments like this:

In Uxxx#yyy, @some-user-name said:

Without setQuoteRef(), the link to the comment won't populate (I think the text just falls back to something generic). You can test this by quoting a comment.

This revision now requires changes to proceed.Apr 14 2017, 1:42 PM
amckinley edited edge metadata.
  • requested changes
This revision is now accepted and ready to land.Apr 17 2017, 5:18 PM
This revision was automatically updated to reflect the committed changes.