Page MenuHomePhabricator

Change PhabricatorPhurlURLViewController to use EditEngine for commenting
ClosedPublic

Authored by amckinley on Apr 13 2017, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 4:48 PM
Unknown Object (File)
Feb 12 2024, 1:11 PM
Unknown Object (File)
Feb 8 2024, 4:07 AM
Unknown Object (File)
Jan 19 2024, 7:14 AM
Unknown Object (File)
Jan 7 2024, 4:38 PM
Unknown Object (File)
Jan 6 2024, 3:35 PM
Unknown Object (File)
Jan 3 2024, 7:32 PM
Unknown Object (File)
Dec 30 2023, 5:41 PM
Subscribers

Details

Test Plan

Created a phurl, added some comments, confirmed that "Change Subscribers" and "Change Project Tags" are now available in the comment form.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad added inline comments.
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
72

Shouldn't need this div.

One minor fix beyond @chad's note.

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
34

While we're here, you can also add:

$timeline->setQuoteRef($url->getMonogram());

That should make the "Quote Comment" action available from the dropdown on the right hand side of comments in the timeline correctly quote comments like this:

In Uxxx#yyy, @some-user-name said:

Without setQuoteRef(), the link to the comment won't populate (I think the text just falls back to something generic). You can test this by quoting a comment.

This revision now requires changes to proceed.Apr 14 2017, 1:42 PM
amckinley edited edge metadata.
  • requested changes
This revision is now accepted and ready to land.Apr 17 2017, 5:18 PM
This revision was automatically updated to reflect the committed changes.