Created a phurl, added some comments, confirmed that "Change Subscribers" and "Change Project Tags" are now available in the comment form.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T11661 (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16465 Build 21918: Run Core Tests Build 21917: arc lint + arc unit
Event Timeline
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php | ||
---|---|---|
71 | Shouldn't need this div. |
Comment Actions
One minor fix beyond @chad's note.
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php | ||
---|---|---|
33 | While we're here, you can also add: $timeline->setQuoteRef($url->getMonogram()); That should make the "Quote Comment" action available from the dropdown on the right hand side of comments in the timeline correctly quote comments like this:
Without setQuoteRef(), the link to the comment won't populate (I think the text just falls back to something generic). You can test this by quoting a comment. |