Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F14097895: D17667.diff
Tue, Nov 26, 7:57 AM
Unknown Object (File)
Wed, Nov 20, 10:31 AM
Unknown Object (File)
Sat, Nov 16, 4:06 AM
Unknown Object (File)
Tue, Nov 12, 8:59 AM
Unknown Object (File)
Thu, Nov 7, 5:12 PM
Unknown Object (File)
Oct 19 2024, 9:10 PM
Unknown Object (File)
Sep 15 2024, 6:46 PM
Unknown Object (File)
Sep 10 2024, 5:01 AM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable