Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F15407305: D17667.diff
Tue, Mar 18, 4:49 PM
F15381989: D17667.id.diff
Fri, Mar 14, 10:14 AM
F15343041: D17667.diff
Sun, Mar 9, 10:09 PM
Unknown Object (File)
Sun, Mar 2, 2:42 PM
Unknown Object (File)
Sun, Feb 23, 12:38 PM
Unknown Object (File)
Sun, Feb 23, 12:07 PM
Unknown Object (File)
Sun, Feb 23, 12:05 PM
Unknown Object (File)
Feb 12 2025, 2:21 AM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable