Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F13226755: D17667.id42499.diff
Sun, May 19, 11:11 PM
F13222789: D17667.diff
Sun, May 19, 3:58 AM
F13217827: D17667.id.diff
Sat, May 18, 8:21 AM
F13208488: D17667.id.diff
Thu, May 16, 4:04 PM
F13205466: D17667.diff
Wed, May 15, 1:58 AM
F13201123: D17667.id42490.diff
Tue, May 14, 8:18 AM
F13190219: D17667.diff
Sat, May 11, 8:30 AM
F13189090: D17667.diff
Sat, May 11, 5:43 AM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Branch
search1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16421
Build 21848: Run Core Tests
Build 21847: arc lint + arc unit