Page MenuHomePhabricator
Differential D17652

When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox
ClosedPublic
Actions

Authored by epriestley on Apr 11 2017, 12:10 AM.
Tags
None
Referenced Files
F19032717: D17652.id.diff
Tue, Nov 25, 7:18 AM
F19025063: D17652.diff
Mon, Nov 24, 5:25 AM
F18968419: D17652.diff
Sat, Nov 15, 1:38 AM
F18960620: D17652.id42454.diff
Thu, Nov 13, 12:06 PM
F18936250: D17652.id.diff
Mon, Nov 10, 8:00 PM
F18864042: D17652.id.diff
Nov 3 2025, 2:18 AM
F18852704: D17652.id42455.diff
Oct 31 2025, 11:29 AM
F18835001: D17652.id.diff
Oct 26 2025, 12:34 PM
View All Files
Subscribers
None

Details

Reviewers
chad
lvital
Maniphest Tasks
T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not
Commits
rP26d6096e0a5b: When reviewing, always show "Accept" checkboxes for packages/projects, even if…
Summary

Fixes T12533.

Test Plan

Screen Shot 2017-04-10 at 5.09.11 PM.png (328×774 px, 34 KB)

Diff Detail

Repository
rP Phabricator
Branch
review1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16384
Build 21793: Run Core Tests
Build 21792: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
xaction/
8 lines

Diff 42454

View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

Loading...
Phabricator · Built by Phacility