Page MenuHomePhabricator
Differential D17652

When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox
ClosedPublic
Actions

Authored by epriestley on Apr 11 2017, 12:10 AM.
Tags
None
Referenced Files
F11156449: D17652.id42455.diff
Mon, Sep 26, 10:41 AM
F11156336: D17652.id.diff
Mon, Sep 26, 10:01 AM
F11156167: D17652.id42454.diff
Mon, Sep 26, 9:04 AM
Unknown Object (File)
Sat, Sep 24, 1:47 PM
Unknown Object (File)
Thu, Sep 22, 12:44 PM
Unknown Object (File)
Tue, Sep 20, 10:58 AM
Unknown Object (File)
Sun, Sep 18, 7:57 AM
Unknown Object (File)
Sat, Sep 17, 10:04 AM
View All 34 Files
Subscribers
None

Details

Reviewers
chad
lvital
Maniphest Tasks
T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not
Commits
rP26d6096e0a5b: When reviewing, always show "Accept" checkboxes for packages/projects, even if…
Summary

Fixes T12533.

Test Plan

Screen Shot 2017-04-10 at 5.09.11 PM.png (328×774 px, 34 KB)

Diff Detail

Repository
rP Phabricator
Branch
review1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16384
Build 21793: Run Core Tests
Build 21792: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
xaction/
8 lines

Diff 42454

View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

Loading...
Phabricator · Built by Phacility