Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
F15381978: D17572.diff
Fri, Mar 14, 10:12 AM
Unknown Object (File)
Fri, Feb 21, 4:37 PM
Unknown Object (File)
Fri, Feb 21, 3:16 PM
Unknown Object (File)
Feb 17 2025, 7:41 AM
Unknown Object (File)
Feb 11 2025, 2:35 PM
Unknown Object (File)
Feb 9 2025, 3:36 AM
Unknown Object (File)
Feb 9 2025, 3:36 AM
Unknown Object (File)
Feb 9 2025, 3:36 AM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable