Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
F14818018: D17572.id42279.diff
Tue, Jan 28, 2:22 AM
F14818017: D17572.id42275.diff
Tue, Jan 28, 2:22 AM
F14818016: D17572.id.diff
Tue, Jan 28, 2:22 AM
Unknown Object (File)
Mon, Jan 27, 2:09 PM
Unknown Object (File)
Sun, Jan 26, 10:45 PM
Unknown Object (File)
Sat, Jan 25, 2:37 PM
Unknown Object (File)
Fri, Jan 24, 7:50 PM
Unknown Object (File)
Fri, Jan 24, 7:50 PM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable