Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 9:08 PM
Unknown Object (File)
Tue, Nov 19, 1:45 AM
Unknown Object (File)
Oct 19 2024, 7:10 PM
Unknown Object (File)
Oct 19 2024, 12:23 AM
Unknown Object (File)
Oct 18 2024, 11:25 AM
Unknown Object (File)
Oct 12 2024, 6:15 PM
Unknown Object (File)
Oct 7 2024, 4:17 AM
Unknown Object (File)
Sep 17 2024, 3:18 AM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable