Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 12:05 PM
Unknown Object (File)
Mon, Apr 8, 8:54 AM
Unknown Object (File)
Tue, Apr 2, 7:08 PM
Unknown Object (File)
Mon, Apr 1, 3:59 PM
Unknown Object (File)
Feb 20 2024, 1:48 PM
Unknown Object (File)
Feb 20 2024, 6:53 AM
Unknown Object (File)
Feb 8 2024, 2:54 PM
Unknown Object (File)
Jan 25 2024, 7:54 PM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Branch
search2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16200
Build 21510: Run Core Tests
Build 21509: arc lint + arc unit