Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
F19517531: D17572.diff
Thu, Jan 15, 12:09 PM
F19345283: D17572.id42275.diff
Fri, Dec 26, 12:59 AM
F19345205: D17572.id42275.diff
Fri, Dec 26, 12:51 AM
F19304167: D17572.diff
Wed, Dec 24, 7:34 AM
F19282510: D17572.id42275.diff
Tue, Dec 23, 4:17 AM
F19123928: D17572.diff
Dec 10 2025, 12:45 AM
F18923809: D17572.diff
Nov 9 2025, 5:03 PM
F18922301: D17572.id.diff
Nov 9 2025, 3:18 PM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Branch
search2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16200
Build 21510: Run Core Tests
Build 21509: arc lint + arc unit