Page MenuHomePhabricator

*Use subversion's internal diff tool for arc diff operation*
Needs ReviewPublic

Authored by papabaer-os on Mar 24 2017, 1:55 AM.
Tags
None
Referenced Files
F19508390: D17547.diff
Sat, Jan 10, 3:57 AM
F18840496: D17547.diff
Oct 28 2025, 1:33 AM
F18776795: D17547.id42207.diff
Oct 10 2025, 11:31 PM
F18762726: D17547.id42240.diff
Oct 6 2025, 8:23 PM
F18753517: D17547.id.diff
Oct 4 2025, 7:13 PM
F18745319: D17547.diff
Oct 3 2025, 6:09 AM
F18733529: D17547.id.diff
Sep 30 2025, 10:36 PM
F18508667: D17547.id.diff
Sep 5 2025, 2:57 AM
Subscribers

Details

Summary

This solves problems described in T2465 "Context not available for
revisions created on Windows"

Test Plan
  • Patch was tested in Windows with svn version 1.9.5 coming with TortoiseSVN version 1.9.5
  • Patch was tested in Linux with svn version 1.9.5

Diff Detail

Repository
rARC Arcanist
Branch
SVN_Use_internal_diff_cmd-T2465
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16155
Build 21440: arc lint + arc unit

Event Timeline

We currently support SVN 1.5 and above

Updating D17547: *Use subversion's internal diff tool for arc diff operation*

Reworked solution to use an arcanist option to enable using subversion's internal diff tool.

Setting arc.diff.svn.use-internal-diff to true will use internal diff while keeping full backward compatibility.