Page MenuHomePhabricator

*Use subversion's internal diff tool for arc diff operation*
Needs ReviewPublic

Authored by papabaer-os on Mar 24 2017, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 5:13 PM
Unknown Object (File)
Fri, Apr 5, 10:52 PM
Unknown Object (File)
Fri, Apr 5, 12:40 PM
Unknown Object (File)
Fri, Apr 5, 11:41 AM
Unknown Object (File)
Fri, Apr 5, 11:41 AM
Unknown Object (File)
Fri, Apr 5, 11:29 AM
Unknown Object (File)
Fri, Apr 5, 8:51 AM
Unknown Object (File)
Fri, Apr 5, 3:52 AM
Subscribers

Details

Summary

This solves problems described in T2465 "Context not available for
revisions created on Windows"

Test Plan
  • Patch was tested in Windows with svn version 1.9.5 coming with TortoiseSVN version 1.9.5
  • Patch was tested in Linux with svn version 1.9.5

Diff Detail

Repository
rARC Arcanist
Branch
SVN_Use_internal_diff_cmd-T2465
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16155
Build 21440: arc lint + arc unit

Event Timeline

We currently support SVN 1.5 and above

Updating D17547: *Use subversion's internal diff tool for arc diff operation*

Reworked solution to use an arcanist option to enable using subversion's internal diff tool.

Setting arc.diff.svn.use-internal-diff to true will use internal diff while keeping full backward compatibility.