Page MenuHomePhabricator
Differential D17427

Filter archived packages out of the "controlling packages" query earlier
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 8:11 PM.
Tags
None
Referenced Files
F18960858: D17427.diff
Thu, Nov 13, 12:21 PM
F18862108: D17427.id41907.diff
Sun, Nov 2, 6:09 PM
F18856179: D17427.id.diff
Sat, Nov 1, 8:22 AM
F18843180: D17427.id41907.diff
Tue, Oct 28, 9:07 PM
F18843179: D17427.id41906.diff
Tue, Oct 28, 9:07 PM
F18843178: D17427.id.diff
Tue, Oct 28, 9:07 PM
F18842107: D17427.diff
Tue, Oct 28, 1:21 PM
F18841494: D17427.id41906.diff
Tue, Oct 28, 9:36 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12319: Investigate an Owners-related performance issue on revision detail pages
Commits
rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier
Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Screen Shot 2017-02-27 at 12.08.44 PM.png (602×2 px, 126 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
query/
18 lines

Diff 41907

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
Phabricator · Built by Phacility