Page MenuHomePhabricator

Filter archived packages out of the "controlling packages" query earlier
ClosedPublic

Authored by epriestley on Feb 27 2017, 8:11 PM.

Details

Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Diff Detail

Repository
rP Phabricator
Branch
owners2
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 15807
Build 20903: Run Core Tests
Build 20902: arc lint + arc unit