Filter archived packages out of the "controlling packages" query earlier
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 8:11 PM.

Tags

None

Referenced Files

	F19049492: D17427.diff
	Thu, Nov 27, 5:31 PM

	F19049476: D17427.diff
	Thu, Nov 27, 5:25 PM

	F18960858: D17427.diff
	Nov 13 2025, 12:21 PM

	F18862108: D17427.id41907.diff
	Nov 2 2025, 6:09 PM

	F18856179: D17427.id.diff
	Nov 1 2025, 8:22 AM

	F18843180: D17427.id41907.diff
	Oct 28 2025, 9:07 PM

	F18843179: D17427.id41906.diff
	Oct 28 2025, 9:07 PM

	F18843178: D17427.id.diff
	Oct 28 2025, 9:07 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12319: Investigate an Owners-related performance issue on revision detail pages

Commits

rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier

Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Screen Shot 2017-02-27 at 12.08.44 PM.png (602×2 px, 126 KB)

Diff Detail

Repository

rP Phabricator

Branch

owners2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15807
Build 20903: Run Core Tests
Build 20902: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2017, 8:11 PM

Harbormaster completed remote builds in B15807: Diff 41906.Feb 27 2017, 8:12 PM

chad accepted this revision.Feb 27 2017, 8:20 PM

This revision is now accepted and ready to land.Feb 27 2017, 8:20 PM

Closed by commit rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2017, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

query/

PhabricatorOwnersPackageQuery.php

18 lines

Diff 41906

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Filter archived packages out of the "controlling packages" query earlierClosedPublicActions