Page MenuHomePhabricator

Filter archived packages out of the "controlling packages" query earlier
ClosedPublic

Authored by epriestley on Feb 27 2017, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 3, 12:48 AM
Unknown Object (File)
May 29 2025, 9:06 AM
Unknown Object (File)
May 10 2025, 1:40 PM
Unknown Object (File)
May 9 2025, 2:48 AM
Unknown Object (File)
Apr 21 2025, 1:17 PM
Unknown Object (File)
Apr 17 2025, 12:48 AM
Unknown Object (File)
Apr 9 2025, 2:21 PM
Unknown Object (File)
Apr 3 2025, 8:10 PM
Subscribers
None

Details

Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Screen Shot 2017-02-27 at 12.08.44 PM.png (602×2 px, 126 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable