Differential D17427

Filter archived packages out of the "controlling packages" query earlier
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 8:11 PM.

Details

Reviewers

chad

Maniphest Tasks

T12319: Investigate an Owners-related performance issue on revision detail pages

Commits

rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier

Summary

Ref T12319. Currently, we end up filtering archived packages out once for each path. This shows up on a profile from an install as meaningfully expensive:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-7kmpevyr22aih4s2vyln/?symbol=PhabricatorOwnersPackage::isArchived

Instead, filter them out before we do any work.

Test Plan

Viewed a revision, still saw packages.

Screen Shot 2017-02-27 at 12.08.44 PM.png (602×2 px, 126 KB)

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 27 2017, 8:11 PM

Harbormaster completed remote builds in B15807: Diff 41906.Feb 27 2017, 8:12 PM

chad accepted this revision.Feb 27 2017, 8:20 PM

This revision is now accepted and ready to land.Feb 27 2017, 8:20 PM

Closed by commit rPa9cd14674503: Filter archived packages out of the "controlling packages" query earlier (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2017, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

query/

PhabricatorOwnersPackageQuery.php

18 lines

Diff 41907

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Filter archived packages out of the "controlling packages" query earlierClosedPublicActions