Page MenuHomePhabricator

Merge multiple Auditors transactions from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:44 PM.
Tags
None
Referenced Files
F15414802: D17403.id41849.diff
Thu, Mar 20, 2:35 AM
F15411587: D17403.id41851.diff
Wed, Mar 19, 9:28 AM
F15411586: D17403.id41849.diff
Wed, Mar 19, 9:28 AM
F15411584: D17403.id.diff
Wed, Mar 19, 9:28 AM
F15411582: D17403.diff
Wed, Mar 19, 9:28 AM
F15394028: D17403.id41851.diff
Sat, Mar 15, 11:19 PM
F15394027: D17403.id41849.diff
Sat, Mar 15, 11:19 PM
F15394026: D17403.id.diff
Sat, Mar 15, 11:19 PM
Subscribers
None

Details

Summary

Fixes T12302. Currently, we aren't merging multiple "AddAuditors" transactions correctly.

This can occur when Herald triggers multiple auditor rules.

Instead, merge them.

Test Plan
  • Wrote two different Herald rules that add auditors.
  • Pushed a commit which triggered them.
  • After the change, saw all the auditors get added correctly.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15746
Build 20809: Run Core Tests
Build 20808: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 23 2017, 11:11 PM
This revision was automatically updated to reflect the committed changes.