Page MenuHomePhabricator

Merge multiple Auditors transactions from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 3:21 AM
Unknown Object (File)
Sun, Feb 9, 3:21 AM
Unknown Object (File)
Sun, Feb 9, 3:21 AM
Unknown Object (File)
Sun, Feb 9, 3:21 AM
Unknown Object (File)
Thu, Jan 30, 5:02 PM
Unknown Object (File)
Tue, Jan 28, 2:28 PM
Unknown Object (File)
Fri, Jan 24, 7:18 PM
Unknown Object (File)
Fri, Jan 24, 7:18 PM
Subscribers
None

Details

Summary

Fixes T12302. Currently, we aren't merging multiple "AddAuditors" transactions correctly.

This can occur when Herald triggers multiple auditor rules.

Instead, merge them.

Test Plan
  • Wrote two different Herald rules that add auditors.
  • Pushed a commit which triggered them.
  • After the change, saw all the auditors get added correctly.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15746
Build 20809: Run Core Tests
Build 20808: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 23 2017, 11:11 PM
This revision was automatically updated to reflect the committed changes.