Page MenuHomePhabricator

Merge multiple Auditors transactions from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:44 PM.
Tags
None
Referenced Files
F19272318: D17403.diff
Mon, Dec 22, 11:06 PM
F19078003: D17403.id.diff
Mon, Dec 1, 4:52 PM
F19068977: D17403.diff
Sun, Nov 30, 12:51 PM
F18853564: D17403.id.diff
Oct 31 2025, 5:54 PM
F18849932: D17403.diff
Oct 30 2025, 1:13 PM
F18843126: D17403.diff
Oct 28 2025, 9:02 PM
F18756606: D17403.id41851.diff
Oct 5 2025, 12:19 PM
F18741817: D17403.diff
Oct 2 2025, 4:14 PM
Subscribers
None

Details

Summary

Fixes T12302. Currently, we aren't merging multiple "AddAuditors" transactions correctly.

This can occur when Herald triggers multiple auditor rules.

Instead, merge them.

Test Plan
  • Wrote two different Herald rules that add auditors.
  • Pushed a commit which triggered them.
  • After the change, saw all the auditors get added correctly.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15746
Build 20809: Run Core Tests
Build 20808: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 23 2017, 11:11 PM
This revision was automatically updated to reflect the committed changes.