Page MenuHomePhabricator

Record command exit status on Execute objects in Phage
ClosedPublic

Authored by epriestley on Feb 19 2017, 2:58 PM.
Tags
None
Referenced Files
F19142558: D17386.diff
Wed, Dec 10, 1:49 PM
F19103971: D17386.id.diff
Fri, Dec 5, 12:36 PM
F19094732: D17386.diff
Thu, Dec 4, 2:05 AM
F18977536: D17386.diff
Nov 16 2025, 6:05 PM
F18855002: D17386.diff
Nov 1 2025, 2:07 AM
F18812954: D17386.id.diff
Oct 20 2025, 1:07 PM
F18765380: D17386.diff
Oct 7 2025, 11:07 AM
F18741473: D17386.id.diff
Oct 2 2025, 1:22 PM
Subscribers
None

Details

Summary

Ref T2794. With Phacility-specific changes elsewhere, this allows me to add some helpful summary output to the current phage UI.

I'm thinking about having a "plan" (a DOM-like document describing which commands to execute where) produce a "report" document, because a command may actually have multiple exit statuses (for example, if it was automatically retried after a failure). But this makes actually using phage to do things quite a bit easier for now.

Test Plan

Ran some cluster operations and, with changes elsewhere, got more useful high-level reporting about overall command state.

Diff Detail

Repository
rPHU libphutil
Branch
phage2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15703
Build 20743: Run Core Tests
Build 20742: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 19 2017, 5:34 PM
This revision was automatically updated to reflect the committed changes.