Page MenuHomePhabricator

Record command exit status on Execute objects in Phage
ClosedPublic

Authored by epriestley on Feb 19 2017, 2:58 PM.
Tags
None
Referenced Files
F15453902: D17386.id.diff
Sat, Mar 29, 2:58 PM
F15448240: D17386.diff
Fri, Mar 28, 3:39 AM
F15422791: D17386.id41809.diff
Sat, Mar 22, 10:45 AM
F15391260: D17386.id41809.diff
Sat, Mar 15, 9:05 AM
F15382360: D17386.diff
Fri, Mar 14, 12:00 PM
F15344273: D17386.id41809.diff
Mon, Mar 10, 3:35 AM
F15334555: D17386.diff
Sat, Mar 8, 10:19 AM
Unknown Object (File)
Feb 21 2025, 3:12 PM
Subscribers
None

Details

Summary

Ref T2794. With Phacility-specific changes elsewhere, this allows me to add some helpful summary output to the current phage UI.

I'm thinking about having a "plan" (a DOM-like document describing which commands to execute where) produce a "report" document, because a command may actually have multiple exit statuses (for example, if it was automatically retried after a failure). But this makes actually using phage to do things quite a bit easier for now.

Test Plan

Ran some cluster operations and, with changes elsewhere, got more useful high-level reporting about overall command state.

Diff Detail

Repository
rPHU libphutil
Branch
phage2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15703
Build 20743: Run Core Tests
Build 20742: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 19 2017, 5:34 PM
This revision was automatically updated to reflect the committed changes.