Page MenuHomePhabricator

Record command exit status on Execute objects in Phage
ClosedPublic

Authored by epriestley on Feb 19 2017, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 9:52 PM
Unknown Object (File)
Tue, Mar 26, 8:41 PM
Unknown Object (File)
Wed, Mar 20, 2:15 PM
Unknown Object (File)
Feb 15 2024, 8:25 AM
Unknown Object (File)
Feb 3 2024, 2:41 PM
Unknown Object (File)
Jan 21 2024, 3:54 AM
Unknown Object (File)
Dec 27 2023, 9:56 AM
Unknown Object (File)
Dec 21 2023, 4:34 PM
Subscribers
None

Details

Summary

Ref T2794. With Phacility-specific changes elsewhere, this allows me to add some helpful summary output to the current phage UI.

I'm thinking about having a "plan" (a DOM-like document describing which commands to execute where) produce a "report" document, because a command may actually have multiple exit statuses (for example, if it was automatically retried after a failure). But this makes actually using phage to do things quite a bit easier for now.

Test Plan

Ran some cluster operations and, with changes elsewhere, got more useful high-level reporting about overall command state.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 19 2017, 5:34 PM
This revision was automatically updated to reflect the committed changes.