Page MenuHomePhabricator

Record command exit status on Execute objects in Phage
ClosedPublic

Authored by epriestley on Feb 19 2017, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 12:42 AM
Unknown Object (File)
Fri, Apr 5, 6:39 PM
Unknown Object (File)
Sun, Mar 31, 7:38 PM
Unknown Object (File)
Fri, Mar 29, 5:53 PM
Unknown Object (File)
Wed, Mar 27, 9:52 PM
Unknown Object (File)
Tue, Mar 26, 8:41 PM
Unknown Object (File)
Mar 20 2024, 2:15 PM
Unknown Object (File)
Feb 15 2024, 8:25 AM
Subscribers
None

Details

Summary

Ref T2794. With Phacility-specific changes elsewhere, this allows me to add some helpful summary output to the current phage UI.

I'm thinking about having a "plan" (a DOM-like document describing which commands to execute where) produce a "report" document, because a command may actually have multiple exit statuses (for example, if it was automatically retried after a failure). But this makes actually using phage to do things quite a bit easier for now.

Test Plan

Ran some cluster operations and, with changes elsewhere, got more useful high-level reporting about overall command state.

Diff Detail

Repository
rPHU libphutil
Branch
phage2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15703
Build 20743: Run Core Tests
Build 20742: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 19 2017, 5:34 PM
This revision was automatically updated to reflect the committed changes.