Fix a property name collision in ArcanistHgServerChannel
ClosedPublic
Actions

Authored by epriestley on Feb 16 2017, 1:11 PM.

Tags

None

Referenced Files

	F15411325: D17366.diff
	Wed, Mar 19, 9:00 AM

	F15411268: D17366.diff
	Wed, Mar 19, 8:57 AM

	F15411204: D17366.diff
	Wed, Mar 19, 8:54 AM

	F15411125: D17366.diff
	Wed, Mar 19, 8:51 AM

	F15411001: D17366.diff
	Wed, Mar 19, 8:46 AM

	F15410927: D17366.diff
	Wed, Mar 19, 8:43 AM

	Unknown Object (File)
	Sun, Mar 2, 3:03 PM

	Unknown Object (File)
	Fri, Feb 28, 1:24 PM

View All Files

Subscribers

None

Details

Reviewers

vrana
chad

Commits

rARC460b0e46eea0: Fix a property name collision in ArcanistHgServerChannel

Summary

See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan

$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.