Fix a property name collision in ArcanistHgServerChannel
ClosedPublic
Actions

Authored by epriestley on Feb 16 2017, 1:11 PM.

Tags

None

Referenced Files

	F19525051: D17366.diff
	Sun, Jan 18, 5:52 AM

	F19525050: D17366.diff
	Sun, Jan 18, 5:52 AM

	F19516282: D17366.id.diff
	Wed, Jan 14, 10:19 PM

	F19514274: D17366.diff
	Wed, Jan 14, 12:09 AM

	F19116987: D17366.id41763.diff
	Dec 9 2025, 7:47 PM

	F19079320: D17366.diff
	Dec 1 2025, 8:50 PM

	F19031791: D17366.diff
	Nov 25 2025, 2:44 AM

	F18843395: D17366.id.diff
	Oct 28 2025, 9:50 PM

View All Files

Subscribers

None

Details

Reviewers

vrana
chad

Commits

rARC460b0e46eea0: Fix a property name collision in ArcanistHgServerChannel

Summary

See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan

$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.