Differential D17361

Restrict all crumbs to 240 max width
ClosedPublic
Actions

Authored by chad on Feb 15 2017, 9:00 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12270: Unbeta Badges

Commits

rPe0cd3062d5ab: Restrict all crumbs to 240 max width

Summary

Ref T12270. Any project, badge, dashboard, etc, that uses names in crumbs can over generate a long title. Restrict to a sane but generous width.

Test Plan

Make a project with a really long name, test various crumb layouts, boards, tasks, desktop, mobile.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 15 2017, 9:00 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 15 2017, 9:00 PM

Harbormaster completed remote builds in B15646: Diff 41750.Feb 15 2017, 9:01 PM

epriestley accepted this revision.Feb 15 2017, 9:03 PM

This revision is now accepted and ready to land.Feb 15 2017, 9:03 PM

Closed by commit rPe0cd3062d5ab: Restrict all crumbs to 240 max width (authored by chad, committed by chad). · Explain WhyFeb 15 2017, 9:06 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).Feb 17 2017, 3:10 PM

epriestley mentioned this in D17382: Revert "Restrict all crumbs to 240 max width" for this release.Feb 17 2017, 11:34 PM

epriestley mentioned this in rPc0cfd4e9aa15: Revert "Restrict all crumbs to 240 max width" for this release.Feb 17 2017, 11:43 PM

What browser did you say you had issues with this on? Safari? I can't reproduce - tried Safari, Chrome, Firefox on Mac:

Safari, issue was with looking at user profiles where the crumb was short (like "alice").

oic

(It would incorrectly render as "ali..." although there was plenty of room for it.)

brb

thx

yeah I can't reproduce that either. are you on an older Safari?

Screen Shot 2017-03-06 at 10.30.19 AM.png (431×565 px, 71 KB)

Seems dependent on the name, let me see if I can get you a better idea of what the repro case is.

Bad:

hector
joedecker
Joey
ducksey

Good:

joseph
alice
jsmith
sloth
pidgeon
omnibus
tortise-list
nnn
UPPERCASE
chrome
saurus

Uh no idea, maybe ending in "r" or "y"? Probably something about font metrics?

Yeah, I tried a dozen usernames, I can't reproduce it.

oh ok, hector reproduces it.

"alice" is good, "alicy" is bad. "UPPERCASE" is good, "UPPERCASEy" is bad. So it depends on the last letter, I guess.

chad mentioned this in D17472: Set a max-width on crumbs just in case.Mar 6 2017, 6:37 PM

chad mentioned this in rP0d12bbb9038c: Set a max-width on crumbs just in case.Mar 6 2017, 6:47 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-crumbs-view.css

4 lines

Diff 41751

View Options

resources/celerity/map.php