Page MenuHomePhabricator

Add more phone numbers to "Shields Up" action
ClosedPublic

Authored by epriestley on Feb 7 2017, 8:27 PM.
Tags
Referenced Files
F12822974: D17323.id.diff
Thu, Mar 28, 7:37 AM
F12822276: D17323.diff
Thu, Mar 28, 7:12 AM
Unknown Object (File)
Tue, Mar 19, 3:47 AM
Unknown Object (File)
Sun, Mar 10, 11:24 PM
Unknown Object (File)
Feb 27 2024, 6:07 AM
Unknown Object (File)
Feb 27 2024, 6:07 AM
Unknown Object (File)
Feb 27 2024, 6:07 AM
Unknown Object (File)
Feb 27 2024, 6:07 AM

Details

Summary

This diff adds phone numbers that were giving us trouble on https://developer.blender.org/

The specific lists of task that included these numbers can be found at https://developer.blender.org/search/query/RVlO.cUv.asA/#R

Test Plan

Create task with these phone numbers

Also, added test coverage.

Diff Detail

Repository
R25 Secure
Branch
morephone
Lint
No Lint Coverage
Unit
Tests Passed
Build Status
Buildable 15610
Build 20599: arc lint + arc unit

Event Timeline

Let's really AMP THIS UP to the NEXT LEVEL 🚀

src/abuse/SecureSheldsUpAction.php
112

Are these "O" ("oh"), not "0" ("zero")? I think the logic below will never match "O" ("oh").

Maybe do this:

  • Put "0" ("zero") in the patterns.
  • Make the logic below replace all "O" ("oh") with "0" ("zero") before performing the match (if ambitious: also replace "i", "I", "l", "L", "|" with "1").
  • While you're here, fix the spelling of "betwee" a few lines below this.
This revision now requires changes to proceed.Feb 7 2017, 8:56 PM
Blendify edited edge metadata.

I changed some things you requested but I do not have enough knowledge of php to do the other part. Maybe use str_replace? Anyway... feel free to commandeer this and make the change

Out of curiosity, why are there "Context not available." indicators here? Am I not supposed to see R25 Secure?

Screen Shot 2017-02-07 at 5.54.21 PM.png (1×2 px, 337 KB)

My guess is it was a cut & paste diff

Yes, I just copied a pasted the diff. I was having an issue getting arc working for https://secure.phabricator.com/

epriestley edited reviewers, added: Blendify; removed: epriestley.

I'll make the other adjustments -- str_replace() is the right approach, but this vital production infrastructure could probably use some unit tests anyway.

epriestley retitled this revision from Secure: add more phone numbers to Add more phone numbers to "Shields Up" action.
epriestley edited the test plan for this revision. (Show Details)
epriestley edited reviewers, added: chad; removed: Blessed Reviewers, Blendify.
epriestley edited projects, added Abuse; removed Security.
  • Add unit tests.
  • Match "o" and "O" for 0, etc.
This revision is now accepted and ready to land.Feb 13 2017, 4:12 PM
This revision was automatically updated to reflect the committed changes.