Page MenuHomePhabricator

Add back the motivator panel
ClosedPublic

Authored by chad on Feb 7 2017, 10:05 PM.
Tags
None
Referenced Files
F14083635: D17324.diff
Sat, Nov 23, 5:06 AM
Unknown Object (File)
Thu, Nov 21, 3:07 PM
Unknown Object (File)
Wed, Nov 20, 7:09 PM
Unknown Object (File)
Mon, Nov 18, 8:15 PM
Unknown Object (File)
Fri, Nov 15, 12:36 PM
Unknown Object (File)
Sun, Nov 10, 8:43 PM
Unknown Object (File)
Thu, Nov 7, 12:30 PM
Unknown Object (File)
Wed, Oct 30, 1:14 AM
Tokens
"Burninate" token, awarded by thoughtpolice."Love" token, awarded by cburroughs.

Details

Summary

Fixes T12226, Ref D17233. Resurrects the motivator panel.

Test Plan

Add panel, see fact on hover.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D17324
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15562
Build 20526: Run Core Tests
Build 20525: arc lint + arc unit

Event Timeline

FWIW, this is the thing that I point someone at when I want to show them how to contribute changes to Phabricator, like just go through the workflow.

Through tireless research, I have discovered additional cat facts which may be candidates for inclusion:

Outside of the CAT scan, cats have made almost no contributions to modern medicine.
In ancient Egypt, the cat-god Horus watched over all cats.
The word "catastrophe" has no etymological relationship to the word "cat".
Many cats appear black in low light, suffering a -2 modifier to luck rolls.
The popular trivia game "World of Warcraft" features a race of cat people called the Khajiit.

This revision is now accepted and ready to land.Feb 8 2017, 5:01 PM

The popular trivia game "World of Warcraft" features a race of cat people called the Khajiit.

😹

This revision was automatically updated to reflect the committed changes.

We could make clicking the item (or any other item) pop up a dialog now fairly easily if you want -- not sure if that's the best direction to take the grand future of Cat Facts, but it's on the table as an easy technical thing if it makes sense here or elsewhere.