Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F13128772: D17282.diff
Wed, May 1, 12:20 AM
Unknown Object (File)
Mon, Apr 29, 5:36 PM
Unknown Object (File)
Sat, Apr 27, 2:26 AM
Unknown Object (File)
Fri, Apr 19, 6:12 PM
Unknown Object (File)
Sun, Apr 7, 10:29 PM
Unknown Object (File)
Tue, Apr 2, 6:08 PM
Unknown Object (File)
Mar 31 2024, 8:59 AM
Unknown Object (File)
Mar 30 2024, 7:13 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable