HomePhabricator

Navigage Buildkite builds with more nuance

Authored by epriestley on Jan 31 2017, 11:31 PM.

Description

Navigage Buildkite builds with more nuance

Summary:
Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.

Test Plan:

  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Reviewers: chad

Reviewed By: chad

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T12173

Differential Revision: https://secure.phabricator.com/D17282

Details

Committed
epriestleyFeb 1 2017, 1:26 AM
Pushed
epriestleyFeb 1 2017, 1:26 AM
Reviewer
chad
Differential Revision
D17282: Navigage Buildkite builds with more nuance
Parents
rP206b16d2bbe8: Slightly better "Simple Dashboard"
Branches
Unknown
Tags
Unknown
Tasks
T12173: Support Buildkite as a Harbormaster target
Build Status
Buildable 15474
Build 20393: Run Core Tests

Event Timeline

chad added a subscriber: chad.Feb 1 2017, 2:00 AM
____________ < Navigage > ------------ \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||

It's a hip neologism made by combining "navigate" and "engage". All the kids are saying it.