Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F14112983: D17282.diff
Thu, Nov 28, 3:21 AM
Unknown Object (File)
Sun, Nov 24, 7:46 AM
Unknown Object (File)
Sat, Nov 23, 5:12 AM
Unknown Object (File)
Sun, Nov 10, 11:09 PM
Unknown Object (File)
Sun, Nov 10, 11:09 PM
Unknown Object (File)
Sun, Nov 10, 11:09 PM
Unknown Object (File)
Sun, Nov 10, 11:09 PM
Unknown Object (File)
Sun, Nov 10, 10:55 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Branch
buildkite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15472
Build 20390: Run Core Tests
Build 20389: arc lint + arc unit