Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F18204494: D17282.id41576.diff
Mon, Aug 18, 1:48 PM
F18201007: D17282.id41574.diff
Mon, Aug 18, 6:17 AM
F18198024: D17282.id41575.diff
Sun, Aug 17, 10:16 PM
F18193887: D17282.id.diff
Sun, Aug 17, 7:21 AM
F18190105: D17282.diff
Sat, Aug 16, 11:27 PM
F18094308: D17282.id.diff
Thu, Aug 7, 10:03 PM
F18086214: D17282.id41575.diff
Tue, Aug 5, 8:09 PM
F17936744: D17282.id.diff
Thu, Jul 31, 12:32 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Branch
buildkite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15473
Build 20392: Run Core Tests
Build 20391: arc lint + arc unit